Homec4science

Improve the flag.* Conduit methods

Authored by Alan Huang <alanh@fb.com> on Aug 3 2012, 20:41.

Description

Improve the flag.* Conduit methods

Summary:

  • Put the code to generate informational dicts about flags into the base class.
  • Update flag.delete to accept an object PHID in order to delete the flag on that object, since currently the model is that each object may have at most one flag, and each flag has exactly one object, although the former is not enforced.
  • Add flag.edit, which creates or updates a flag, optionally with the given color and note.

Test Plan:
Spend endless hours repeatedly running arc call-conduit and
arc flag.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3141

Details

Committed
Alan Huang <alanh@fb.com>Aug 3 2012, 20:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc691d4bfa99e: Merge pull request #172 from floatingLomas/arcpatch-D3109
Branches
Unknown
Tags
Unknown

Event Timeline

Alan Huang <alanh@fb.com> committed rPH358baf1b3a18: Improve the flag.* Conduit methods (authored by Alan Huang <alanh@fb.com>).Aug 3 2012, 20:41