Homec4science

Unify changeset line ID rendering and bring it to unified diffs

Authored by epriestley <git@epriestley.com> on Mar 5 2015, 23:03.

Description

Unify changeset line ID rendering and bring it to unified diffs

Summary:
Ref T2009. Currently, lines don't get their "C123NL456" IDs set in the unified view. This is the major way that inlines are glued to changesets.

Simplify this rendering and bring it into the HTML renderer, then use it in the OneUp renderer.

Test Plan:

  • Interacted with side-by-side inlines (hovered, added, edited, deleted), saw unchanged behavior.
  • Interacted with unified inlines. They still don't work, but the error that breaks them is deeper in the stack.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D11983

Details

Committed
epriestley <git@epriestley.com>Mar 5 2015, 23:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcb886eb60eed: Share code for context link rendering on side-by-side diffs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH35c1dbf1f8a4: Unify changeset line ID rendering and bring it to unified diffs (authored by epriestley <git@epriestley.com>).Mar 5 2015, 23:03