Homec4science

Merge `diffusion.commitbranchesquery` into `diffusion.branchquery`

Authored by epriestley <git@epriestley.com> on Jan 18 2014, 01:11.

Description

Merge diffusion.commitbranchesquery into diffusion.branchquery

Summary:
Ref T4327. This is general cleanup since I was in this area of the code. Primarily, the Mercurial implementation here was completely broken and wrong:

  • It returned only one branch, but a commit can be present on many branches.
  • It did not account for multiple branch heads.
  • It returned a result implying the branch head pointed at the queried commit, which is no consistent or accurate.

Simplify the amount of API we're dealing with by collapsing this method into the very similar diffusion.branchquery method.

Test Plan: Looked at mercurial and git repositories and commits, branch information seemed correct.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4327

Differential Revision: https://secure.phabricator.com/D8003

Details

Committed
epriestley <git@epriestley.com>Jan 18 2014, 01:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4c2696120b81: Remove DiffusionBranchInformation in favor of DiffusionRepositoryRef
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH35ccda922a31: Merge `diffusion.commitbranchesquery` into `diffusion.branchquery` (authored by epriestley <git@epriestley.com>).Jan 18 2014, 01:11