Homec4science

Prevent locked credentials from being made accessible via conduit

Authored by epriestley <git@epriestley.com> on May 18 2016, 21:31.

Description

Prevent locked credentials from being made accessible via conduit

Summary:
Via HackerOne. Currently, you can use "Lock Permanently" to lock a credential permanently, but you can still enable Conduit API access to it. This directly contradicts both intent of the setting and its description as presented to the user.

Instead:

  • When a credential is locked, revoke Conduit API access.
  • Prevent API access from being enabled for locked credentials.
  • Prevent API access to locked credentials, period.

Test Plan:

  • Created a credential.
  • Enabled API access.
  • Locked credential.
  • Saw API access become disabled.
  • Tried to enable API access; was rebuffed.
  • Queried credential via API, wasn't granted access.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15944

Details

Committed
epriestley <git@epriestley.com>May 18 2016, 23:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0308d580d7df: Deactivate SSH keys instead of destroying them completely
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH36006bcb8fcb: Prevent locked credentials from being made accessible via conduit (authored by epriestley <git@epriestley.com>).May 18 2016, 23:54