Homec4science

Remove obsolete code from ManiphestTaskQuery

Authored by epriestley <git@epriestley.com> on Sep 25 2013, 22:44.

Description

Remove obsolete code from ManiphestTaskQuery

Summary:
Ref T603. Cleans up some obsolete stuff here:

  • We no longer ever query by min/max priority (instead, withPriorities(...)).
  • A parent class provides limit/offset.
  • Result count is no longer reliable with policies. We could do "about X tasks" or something, but just drop it for now. There's only one remaining callsite anyway.

Test Plan:

  • grep
  • Viewed task list.
  • Viewed a project page.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7121

Details

Committed
epriestley <git@epriestley.com>Sep 25 2013, 22:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3a87a95e119b: Use ManiphestTaskQuery in nearly all interfaces
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH36343600c5c7: Remove obsolete code from ManiphestTaskQuery (authored by epriestley <git@epriestley.com>).Sep 25 2013, 22:44