Homec4science

Fix an issue with mentioning revisions on the new EditEngine code

Authored by epriestley <git@epriestley.com> on Dec 14 2016, 23:00.

Description

Fix an issue with mentioning revisions on the new EditEngine code

Summary:
Ref T12020. Ref T11114. If we continue here on a mention, we try to generate $old, which requires reviewers to be attached. They won't be for simple codepaths like mentions.

Instead, just bail early: we don't need to do anything anyway since we can't possibly find any more errors with zero transactions.

Test Plan: Mentioned a revision on a task.

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T11114, T12020

Differential Revision: https://secure.phabricator.com/D17059

Details

Committed
epriestley <git@epriestley.com>Dec 14 2016, 23:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe077d2f7a79a: Reorganize phui-object-item CSS, add drag ui
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH378387a0785f: Fix an issue with mentioning revisions on the new EditEngine code (authored by epriestley <git@epriestley.com>).Dec 14 2016, 23:11