Homec4science

Throw when callers pass an invalid constraint to a "*.search" method

Authored by epriestley <git@epriestley.com> on Sep 7 2016, 16:21.

Description

Throw when callers pass an invalid constraint to a "*.search" method

Summary:
Ref T11593. When you call a *.search method like maniphest.search, we don't currently validate that all the constraints you pass are recognized.

I think there were two very weak arguments for not doing this:

  • It makes compatibility in arc across versions slightly easier: if we add a new constraint, we could add it to arc but also do client-side filtering for a while.
  • Conduit parameter types could, in theory, accept multiple inputs or optional/alias inputs.

These reasons are pretty fluff and T11593 is a concrete issue caused by not validating. Just validate instead.

Test Plan:

  • Made a maniphest.search call with a bogus constraint, got an explicit error about the bad constraint.
  • Made a maniphest.search call with a valid constraint ("ids").

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11593

Differential Revision: https://secure.phabricator.com/D16507

Details

Committed
epriestley <git@epriestley.com>Sep 7 2016, 18:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9ced2d7eb514: Basic kbd CSS for remarkup
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH38ae81fb3916: Throw when callers pass an invalid constraint to a "*.search" method (authored by epriestley <git@epriestley.com>).Sep 7 2016, 18:07