Homec4science

Improve "unblock task" feed stories

Authored by epriestley <git@epriestley.com> on Aug 12 2014, 18:27.

Description

Improve "unblock task" feed stories

Summary:
Fixes T5184. Fixes T5008. Three issues with stories/notifications about changing the status of tasks which block other tasks:

Bad Feed Stories

  • Problem: Feed story rendering was confusing (T5184).
  • Solution: fix it to provide context.

Too Many Feed Stories

  • Problem: Feed gets a story for the original task's close ("a closed x"), and a story for each blocked task ("a closed x, a task blocking y").
  • "Solution": Punt. These are redundant in the full feed but not in filtered feeds. Right solution is display-time aggregation. No users have really complained about this.

Too Many Notifications

  • Problem: Users subscribed to both tasks get notified about the clsoe, and also about the unblocked task. These notifications are redundant.
  • "Solution": Punt. This is easy to fix by silencing notifications for the sub-editor, but I'm worried it would be confusing. Users haven't complained. Display-time aggregation might be a better fix.

Test Plan: {F189463}

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5008, T5184

Differential Revision: https://secure.phabricator.com/D10235

Details

Committed
epriestley <git@epriestley.com>Aug 12 2014, 18:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH94389fcd9f58: Allow projects to be filtered by icon and color
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH394250397ec4: Improve "unblock task" feed stories (authored by epriestley <git@epriestley.com>).Aug 12 2014, 18:27