Homec4science

Prevent Phabot from spinning out of control

Authored by epriestley <git@epriestley.com> on Jul 3 2011, 15:07.

Description

Prevent Phabot from spinning out of control

Summary: When the remote closes the connection, phabot goes into a busy loop
because of PHP's "nothing should ever be an error" semantics. Instead, detect
connection termination.
Test Plan: Disabled the "PONG" response in the protocol handler and let freenode
disconnect phabot. It spun out of control before, now it detects the issue and
exits to await automatic restart.
Reviewed By: jungejason
Reviewers: codeblock, jungejason, aran, tuomaspelkonen
CC: aran, jungejason
Differential Revision: 582

Details

Committed
epriestley <git@epriestley.com>Jul 3 2011, 18:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcd47271cf5e7: Handle the case when a repository was deleted
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH39adae9aa85e: Prevent Phabot from spinning out of control (authored by epriestley <git@epriestley.com>).Jul 3 2011, 18:58