Homec4science

Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversion

Authored by epriestley <git@epriestley.com> on Aug 12 2016, 00:07.

Description

Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversion

Summary:
I converted this call incorrectly in D16092. We should pass the PhutilURI object, not the string version of it.

Specifically, this resulted in hitting an error like this if a replica needed synchronization:

[2016-08-11 21:22:37] EXCEPTION: (InvalidArgumentException) Argument 1 passed to DiffusionCommandEngine::setURI() must be an instance of PhutilURI, string given, called in...
#0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/diffusion/protocol/DiffusionCommandEngine.php:52]
#1 DiffusionCommandEngine::setURI(string) called at [<phabricator>/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php:601]
...

Test Plan: Clusterized an observed repository, demoted a node, ran bin/repository update Rxxx to update, saw no typehint fatal.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16390

Details

Committed
epriestley <git@epriestley.com>Aug 12 2016, 01:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5e3efca08a57: In taskmaster daemons, only close connections which were not used recently
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH39d4e21eec56: Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversion (authored by epriestley <git@epriestley.com>).Aug 12 2016, 01:41