Homec4science

Don't choke on copy-pasted diffs which include commit messages

Authored by epriestley <git@epriestley.com> on Oct 19 2012, 19:29.

Description

Don't choke on copy-pasted diffs which include commit messages

Summary: If you git show and copy/paste it into Differential, we die trying to save the DifferentialChangeset corresponding to the commit message (error: column "filename" can not be null). Instead, drop the message change for raw diffs.

Test Plan: Copy/pasted git show into Differential.

Reviewers: btrahan, vrana

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D3740

Details

Committed
epriestley <git@epriestley.com>Oct 19 2012, 19:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe14930f860c4: Provide assist for Remarkup table
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3a8be549d62f: Don't choke on copy-pasted diffs which include commit messages (authored by epriestley <git@epriestley.com>).Oct 19 2012, 19:29