Homec4science

Differential - add a configuration option to allow any user to close a revision…

Authored by Bob Trahan <bob.trahan@gmail.com> on Aug 28 2012, 23:17.

Description

Differential - add a configuration option to allow any user to close a revision that has been accepted

Summary: this is useful for certain workflows, typically where the reviewer is a gatekeeper of sorts who does the acutal commit. Special thanks to D2900 which made this relatively brain-dead to code up.

Test Plan: set to "true" in my local development environment and verified test user "xerxes" could close my stuff

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1732

Differential Revision: https://secure.phabricator.com/D3398

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Aug 28 2012, 23:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcdfc71ced51c: Only send the "this is blank silly" error message email if the email is sent…
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH3aa54782a791: Differential - add a configuration option to allow any user to close a revision… (authored by Bob Trahan <bob.trahan@gmail.com>).Aug 28 2012, 23:17