Homec4science

Cache the computation of the custom block component of the markup key

Authored by epriestley <git@epriestley.com> on Nov 14 2013, 02:08.

Description

Cache the computation of the custom block component of the markup key

Summary:
Caught this taking way too long on a production profile:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-vfzq3sregh5xvpf5nc2t/?symbol=PhabricatorMarkupEngine::getMarkupFieldKey

Cache it; it's always identical.

Test Plan: Loaded Conpherence locally.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7583

Details

Committed
epriestley <git@epriestley.com>Nov 14 2013, 02:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPH87a655e8c53c: Fix new logged-out "Login" button URI and workflowiness
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3b257381ada0: Cache the computation of the custom block component of the markup key (authored by epriestley <git@epriestley.com>).Nov 14 2013, 02:08