Homec4science

Fix two transactional issues around revision status

Authored by epriestley <git@epriestley.com> on Mar 12 2014, 23:24.

Description

Fix two transactional issues around revision status

Summary:
Two issues:

  • Herald is currently overwriting accepts and rejects with "blocking reviewer". Just stop it from doing that.
  • When you update an accepted revision, we put it back in "needs review", then return it to "accepted", generating an extra transaction. Instead, don't.

Test Plan:

  • Updated a revision with an accepting, herald-based blocking project reviewer. Reviewer was still accepting.
  • Updated an accepted revision, didn't get an extra transaction.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Differential Revision: https://secure.phabricator.com/D8506

Details

Committed
epriestley <git@epriestley.com>Mar 12 2014, 23:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPH193e8a54fc20: Add "pusher is committer" to Herald as a pre-commit rule
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3b861ab7411d: Fix two transactional issues around revision status (authored by epriestley <git@epriestley.com>).Mar 12 2014, 23:24