Homec4science

Allow disabling JX.Workflow with keyboard modifier

Authored by vrana <jakubv@fb.com> on Apr 18 2012, 22:26.

Description

Allow disabling JX.Workflow with keyboard modifier

Summary:
Ctrl+click opens the link to a new tab in most browsers.
Shift+click to a new window.
Alt+click or Meta+click downloads the target.

This diff respects these conventions by disabling JX.Workflow for these modifiers.

Test Plan:
Click Flag Task - inline dialog.
Ctrl+click Flag Task - new tab with standalone dialog.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2276

Details

Committed
vrana <jakubv@fb.com>Apr 18 2012, 22:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH401ac19aa6a1: Reorder the daemon console's display of the panels
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH3c22bebc9bf4: Allow disabling JX.Workflow with keyboard modifier (authored by vrana <jakubv@fb.com>).Apr 18 2012, 22:47