Homec4science

include task ids in the commit messages returned by "arc amend"

Authored by mgummelt <mgummelt@fb.com> on Jun 29 2011, 00:47.

Description

include task ids in the commit messages returned by "arc amend"

Summary:
when "arc diff" generates a revision, it attaches a task id
if one is included. However, "arc amend" did not return a task id,
effectively stripping it from the commit message. This diff fixes
that.

NOTE: This is dependent on revision 549 https://secure.phabricator.com/D549

Test Plan:
0. created a custom class to append Facebook task IDs to commit messages and
attached it to the differential.append-commit-message-class config variable

  1. created a new diff in the www repot
  2. included Task ID: 609350 in the git commit message
  3. "arc diff" to generate the revision
  4. "arc amend"
  5. ensure that the "Task ID:" field remained in the git commit message

Reviewed By: epriestley
Reviewers: dpepper, jungejason, epriestley
CC: aran, epriestley, mgummelt
Differential Revision: 546

Details

Committed
mgummelt <mgummelt@fb.com>Jun 30 2011, 01:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHae78ea38e66c: added commit message field class
Branches
Unknown
Tags
Unknown

Event Timeline

mgummelt <mgummelt@fb.com> committed rPH3c785cdb5a9b: include task ids in the commit messages returned by "arc amend" (authored by mgummelt <mgummelt@fb.com>).Jun 30 2011, 01:28