Homec4science

Fix comment anchor jump highlighting

Authored by epriestley <git@epriestley.com> on Jan 24 2012, 02:09.

Description

Fix comment anchor jump highlighting

Summary: I accidentally broke the feature where we highlight comments which are
jumped to via anchor in D1327. We now test that the jump was sucessful by
looking for an item with the anchor ID, but we were only setting 'name'.
Instead, set 'id' as well so the highlighting code detects that the jump was
successful and adds the highlight class.

Test Plan: Clicked "Comment D1234#7" or whatever, got a nice yellow background.

Reviewers: btrahan, nh, jungejason

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T796

Differential Revision: https://secure.phabricator.com/D1471

Details

Committed
epriestley <git@epriestley.com>Jan 24 2012, 18:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7d1f62409d2e: Move resource allocation to task queue
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3c8bb8a6083f: Fix comment anchor jump highlighting (authored by epriestley <git@epriestley.com>).Jan 24 2012, 18:44