Homec4science

Fix weird remarkup linewrapping on a few instructions forms, plus move toward…

Authored by epriestley <git@epriestley.com> on May 22 2016, 18:54.

Description

Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues

Summary:
Fixes T10381. When we converted to PHUIRemarkupView, some instructional text got linebreaks added when it shouldn't have them (the source is written in PHP and wrapped at 80 characters, but the output should flow naturally).

Fix this so we don't preserve linebreaks.

This also makes PHUIRemarkupView a little more powerful and inches us toward fixing Phame/CORGI remarkup issues, getting rid of PhabricatorMarkupInterface / PhabricatorMarkupOneOff, and dropping all the application hard-coding in PhabricatorMarkupEngine.

Test Plan:

  • Grepped for all callsites, looking for callsites which accept remarkup written in <<<HEREDOC format.
  • Viewed form instructions, Conduit API methods, HTTP parameter edit instructions.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10381

Differential Revision: https://secure.phabricator.com/D15963

Details

Committed
epriestley <git@epriestley.com>May 22 2016, 21:23
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2a00f185eb2f: When the JS "Intl" API is available, use it to guess the timezone
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3d3fff4991ab: Fix weird remarkup linewrapping on a few instructions forms, plus move toward… (authored by epriestley <git@epriestley.com>).May 22 2016, 21:23