Homec4science

[Redesign] Put all ApplicationSearch results in an ObjectBox

Authored by Chad Little <chad@phacility.com> on May 24 2015, 18:13.

Description

[Redesign] Put all ApplicationSearch results in an ObjectBox

Summary:
Ref T8099. In most cases we return either an ObjectList or AphrontTable, and can pretty up the UI in ApplicationSearch. There are a few edge cases, like PeopleUserLog, that can be cleanup up individually in the future, but look fine for now.
Also added 'setNotice' for AphrontTable for a few cases where we want to convey addtional information.

TODO: Seems we always pass a Pager Object, which tries to get displayed, I'll redesign that interaction in the future, probably by passing the Pager to the ObjectBox

Test Plan: Went throught most/all ApplicationSearch panels I could find, even edge cases look better.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D12989

Details

Committed
Chad Little <chad@phacility.com>May 24 2015, 18:13
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc371077bbe2d: [Redesign] Thinner PHUIPinboardItemView
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@phacility.com> committed rPH3d407732d623: [Redesign] Put all ApplicationSearch results in an ObjectBox (authored by Chad Little <chad@phacility.com>).May 24 2015, 18:13