Homec4science

Make .ics export less scary and attach .ics files to event mail

Authored by epriestley <git@epriestley.com> on Sep 15 2016, 15:27.

Description

Make .ics export less scary and attach .ics files to event mail

Summary:
Ref T10747.

  • Remove the warning dialog since these files don't seem to do anything confusing/problematic in Calendar.app or Google Calendar. Those importers generally need to be defensive about how they handle random ".ics" files from arbitrary third parties anyway, and this makes testing imports easier since we have a GET-table ".ics" URI for public events.
  • Attach ".ics" files to email.

Test Plan:

  • Clicked "Export as .ics", got an ICS file.
  • Used "bin/mail show-outbound" to review an ICS attachment, although I don't actually have real mail set up locally so this may still be a little funky.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16559

Details

Committed
epriestley <git@epriestley.com>Sep 15 2016, 19:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH96f800249b31: Export ORGANIZER and ATTENDEE sections in ".ics" files from Calendar
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3d6c3c2c45e8: Make .ics export less scary and attach .ics files to event mail (authored by epriestley <git@epriestley.com>).Sep 15 2016, 19:33