Homec4science

Fix some warnings about markup engines in Audit/Diffusion inline comments

Authored by epriestley <git@epriestley.com> on Mar 20 2012, 03:17.

Description

Fix some warnings about markup engines in Audit/Diffusion inline comments

Summary:
Split from D1921.

  • DifferentialChangesetParser doesn't have this property declared.
  • We weren't providing a markup engine, which caused some warnings.
  • This would cause failures if comment caches weren't present. Currently, they always will be though unless someone has wiped them explicitly in the DB.

Test Plan: Viewed a diff with inline comments, didn't get any warnings in the log.

Reviewers: nh, vrana, btrahan

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1925

Details

Committed
epriestley <git@epriestley.com>Mar 20 2012, 03:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8c141fdfd1bf: Fix an issue where DiffusionGitBrowseQuery incorrectly parses filenames with…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3db02a584cd0: Fix some warnings about markup engines in Audit/Diffusion inline comments (authored by epriestley <git@epriestley.com>).Mar 20 2012, 03:17