Homec4science

Feed - fix some whacky "text mode" rendering code

Authored by Bob Trahan <btrahan@phacility.com> on Apr 10 2014, 22:46.

Description

Feed - fix some whacky "text mode" rendering code

Summary: ...add a "renderingTarget" to FeedStory and use it as appropos. Overall, not a ton of changes was necessary to make this work. I think this could be made to be even cleaner by going through each and every feed story and re-implementing as necessary with the full toolset available. But this is good enough for now I think, and just something to keep cleaning up when we're in here. Fixes T4630.

Test Plan: made a task. gave it a token. viewed my feed - saw stories. used conduit.feed.query with mode == 'text' and got good readable results.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: spicyj, epriestley, Korvin

Maniphest Tasks: T4630

Differential Revision: https://secure.phabricator.com/D8750

Details

Committed
Bob Trahan <btrahan@phacility.com>Apr 10 2014, 22:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4b56dbed3a72: Herald - make tokenizers have the purdy icons
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH3e0b3a1db5db: Feed - fix some whacky "text mode" rendering code (authored by Bob Trahan <btrahan@phacility.com>).Apr 10 2014, 22:46