Homec4science

getConfigEnv fails fast when key is not found and no default value is given.

Authored by Nick Pellegrino <nickpell@alum.mit.edu> on Jan 19 2013, 21:11.

Description

getConfigEnv fails fast when key is not found and no default value is given.

Summary:
T2345
getConfig throws an Exception when the key does not exist.
Also removes dead code that throws an Exception.

Test Plan:
Reloaded the Phabricator home page. In the process, found
2 Exceptions thrown due to nonexistent keys. After addressing these problems,
the home page loads without Exceptions.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4541

Details

Committed
epriestley <git@epriestley.com>Jan 19 2013, 21:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPH06bca93b47b4: Expanded Regexp for matching tasks to include more tenses
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3e6fa4365811: getConfigEnv fails fast when key is not found and no default value is given. (authored by Nick Pellegrino <nickpell@alum.mit.edu>).Jan 19 2013, 21:11