Homec4science

Fix an incorrect filtering of groupless results from Maniphest "Group By" query

Authored by epriestley <git@epriestley.com> on May 16 2014, 17:47.

Description

Fix an incorrect filtering of groupless results from Maniphest "Group By" query

Summary:
Fixes T5081. This block enforces policies and prevents you from seeing groups associated with projects you can't see. However, it incorrectly removes tasks which end up with no group key. This can happen in two cases:

  • The task isn't in a project.
  • The task is in a project, but the query includes an "In All Projects: <that project>" constraint. In that case, we don't show the group becuase it would always contain every task.

Test Plan:
Replicated the setup in T5081, saw an "Ungrouped" group with "Task A":

{F155766}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5081

Differential Revision: https://secure.phabricator.com/D9152

Details

Committed
epriestley <git@epriestley.com>May 16 2014, 17:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4925dd7e6eea: Remove documentation about obsolete Differential event listeners
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3e9a988cd71f: Fix an incorrect filtering of groupless results from Maniphest "Group By" query (authored by epriestley <git@epriestley.com>).May 16 2014, 17:47