Homec4science

Share more HTTPSink code

Authored by epriestley <git@epriestley.com> on Dec 25 2012, 15:17.

Description

Share more HTTPSink code

Summary:
In the past, we did some additional magic on $response_string (adding profiling headers? Or DarkConsole?), so we could not share the pathway with HTTPSink. We no longer do this; share the pathways.

Also remove error handler initialization (duplicated in PhabricatorEnv), and move $sink initialization earlier. My general goal here is to allow PhabricatorSetup to emit a normal Response object and share as much code as possible with normal pages.

Test Plan: Loaded page.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2228

Differential Revision: https://secure.phabricator.com/D4285

Details

Committed
epriestley <git@epriestley.com>Dec 25 2012, 15:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9e6d59829ced: Consolidate environmental initialization
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3eb370a5331e: Share more HTTPSink code (authored by epriestley <git@epriestley.com>).Dec 25 2012, 15:17