Homec4science

In prose diff dialogs (like "Show Details" in transactions), show "old", "new"…

Authored by epriestley <git@epriestley.com> on Nov 7 2016, 20:19.

Description

In prose diff dialogs (like "Show Details" in transactions), show "old", "new" and "diff" tabs

Summary:
Ref T7643. When you do something like this:

  • Edit a task description.
  • Click "Show Details" on the resulting transaction.
  • Get a prose diff dialog showing the change.

...now add some "Old" and "New" tabs. These are useful for:

  • reverting to the old text by copy/pasting;
  • reading just the new/old text if the diff is noisy;
  • sometimes just nice to have?

(This looks a little rough but I didn't want to put a negative margin on tab groups inside dialogs? Not sure what the best fix here is.)

Test Plan: {F1909390}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7643

Differential Revision: https://secure.phabricator.com/D16817

Details

Committed
epriestley <git@epriestley.com>Nov 8 2016, 00:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6a7dde03ccfb: On `@username` mentions in remarkup, show the "busy" dot color
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH3f5109b66864: In prose diff dialogs (like "Show Details" in transactions), show "old", "new"… (authored by epriestley <git@epriestley.com>).Nov 8 2016, 00:18