Homec4science

Don't barf on bad commit identifiers

Authored by Nick Harper <nharper@fb.com> on Mar 19 2013, 23:30.

Description

Don't barf on bad commit identifiers

Summary:
If someone provides an invalid svn rev number (like providing a git commit
hash instead) for a diffusion commit, we should ignore it like we ignore
other bad input to DiffusionCommitQuery, instead of barfing.

Test Plan:
put an invalid blame rev with rEsomehash (where E is an svn repo), and
differential loads.

Reviewers: epriestley, wez

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5389

Details

Committed
Nick Harper <nharper@fb.com>Mar 19 2013, 23:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH34e0f617a5b2: Adding trailing slash to 'Edit Mock' URI
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH3f708710eb8d: Don't barf on bad commit identifiers (authored by Nick Harper <nharper@fb.com>).Mar 19 2013, 23:30