Homec4science

Removed broken inline comment anchors.

Authored by tuomaspelkonen <tuomas.pelkonen@fb.com> on Apr 15 2011, 02:22.

Description

Removed broken inline comment anchors.

Summary:
Inline comment anchros were present for all different diffs inside a
revision. They were only working for the current diff. Removed the
links that were for different diffs.

I couldn't get the automatic linking to other diffs working, probably
because the anchors didn't work when the page was reloaded. This is also
a bit confusing if the diff changes when clicking on anchor.

We might want to carry all the comments along in the future, but I
don't think it's needed at the moment.

Test Plan:
Tested on a revision, which had inline comments for differerent diffs
that only the comments for the latest diff had anchors when the page
was loaded. Changed the diff manually on the page and made sure the
anchors for that diff were working correctly and the anchors for the
latest diff were not available.

Reviewed By: epriestley
Reviewers: epriestley
CC: jungejason, epriestley
Differential Revision: 142

Details

Committed
tuomaspelkonen <tuomas.pelkonen@fb.com>Apr 15 2011, 04:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPH927407c4269d: Be more explicit about PHID sourcing in PhabricatorObjectSelectorDialog
Branches
Unknown
Tags
Unknown

Event Timeline

tuomaspelkonen <tuomas.pelkonen@fb.com> committed rPH40554e2d8aef: Removed broken inline comment anchors. (authored by tuomaspelkonen <tuomas.pelkonen@fb.com>).Apr 15 2011, 04:03