Homec4science

Modernize more paging/order queries

Authored by epriestley <git@epriestley.com> on Apr 12 2015, 07:26.

Description

Modernize more paging/order queries

Summary:
Ref T7803. Removes some getReversePaging().

This also fixes null column handling, by adding an explicit 'null' key with possible values "head" (put NULL before other values) or "tail" (put NULL after other values).

Maniphest has some glitchiness in paging through NULLs right now, but I believe it's all pre-existing and will be resolved when it fully converts. Diffusion is fully converted and pages through NULL correctly.

Test Plan:

  • Failed to identify any reason for ChangesetQuery to reverse paging.
  • Paged thorugh Diffusion.
  • Paged through Maniphest.
    • Maniphest has some issues when paging inside a NULL section, but these issues are preexisting and will be resolved later in this change sequence.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7803

Differential Revision: https://secure.phabricator.com/D12371

Details

Committed
epriestley <git@epriestley.com>Apr 13 2015, 20:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9c7c13ffc88a: Modernize Phrequent and Commit query ordering/paging
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH411456084448: Modernize more paging/order queries (authored by epriestley <git@epriestley.com>).Apr 13 2015, 20:58