Homec4science

Improve inline mail snippet rendering, possibly fixing Airmail?

Authored by epriestley <git@epriestley.com> on May 6 2016, 20:46.

Description

Improve inline mail snippet rendering, possibly fixing Airmail?

Summary:
Ref T10694. General improvements:

  • Remove leading empty lines from context snippets.
  • Remove trailing empty lines from context snippets.
  • If we removed everything, render a note.
  • Try using style instead of <pre>? My thinking is that maybe Airmail has weird default rules for <pre>, since that's the biggest / most obvious thing that's different about this element to me.

Test Plan: Viewed normal comments locally, faked a comment on an empty line in the middle of a lot of other empty lines.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10694

Differential Revision: https://secure.phabricator.com/D15864

Details

Committed
epriestley <git@epriestley.com>May 6 2016, 20:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH371051ff3779: Minor tweaks to pre/inline style for inline comments in HTML mail
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH412fc3455730: Improve inline mail snippet rendering, possibly fixing Airmail? (authored by epriestley <git@epriestley.com>).May 6 2016, 20:58