Homec4science

Mark `renderActionDescription` as abstract

Authored by Joshua Spence <josh@joshuaspence.com> on Aug 4 2015, 00:26.

Description

Mark renderActionDescription as abstract

Summary:
I got caught by this... my custom Herald action doesn't implement this method and now I am hitting this exception:

Call to undefined method HeraldHipChatNotificationAction::renderActionDescription()

/usr/src/phabricator/src/applications/herald/adapter/HeraldAdapter.php:896

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13779

Details

Committed
Joshua Spence <josh@joshuaspence.com>Aug 4 2015, 00:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5f76c71d781c: Share target filtering code in HeraldAction
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH4139305f73f0: Mark `renderActionDescription` as abstract (authored by Joshua Spence <josh@joshuaspence.com>).Aug 4 2015, 00:33