Homec4science

Make HTTP errors returned from the Aphlict server more specific

Authored by Joshua Spence <josh@joshuaspence.com> on Jul 18 2014, 01:01.

Description

Make HTTP errors returned from the Aphlict server more specific

Summary: Ref T5651. Currently, the Aphlict server returns either 200 OKAY or 400 Bad Request. We could return more specific errors in some cases and this may assist with debugging.

Test Plan:
Sent myself a test notification at /notification/status/ and saw the Aphlict server process the request (running in debug mode). Also poked around with curl:

> curl http://localhost:22281/
405 Method Not Allowed

> curl http://localhost:22281/ -d ""
400 Bad Request

> curl http://localhost:22281/foobar/
404 Not Found

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5651

Differential Revision: https://secure.phabricator.com/D9967

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jul 18 2014, 01:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH45ea88cec486: Add more columns to typeahead wire format debugging view
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH41a8837f78db: Make HTTP errors returned from the Aphlict server more specific (authored by Joshua Spence <josh@joshuaspence.com>).Jul 18 2014, 01:01