Homec4science

Disable JSON shield for uncaught exception responses to Conduit requests

Authored by epriestley <git@epriestley.com> on Mar 31 2013, 04:04.

Description

Disable JSON shield for uncaught exception responses to Conduit requests

Summary: Modern conduit responses should never have a JSON shield. We disable it for normal responses, but uncaught exceptions hit this higher-level handler block which fails to disable the shield. Disable the shield.

Test Plan: Inspection.

Reviewers: btrahan, andrewjcg

Reviewed By: andrewjcg

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5483

Details

Committed
epriestley <git@epriestley.com>Mar 31 2013, 04:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe80c59cbc622: Introduce basic `bin/mail` with a `resend` workflow
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH41b32d5fbe9d: Disable JSON shield for uncaught exception responses to Conduit requests (authored by epriestley <git@epriestley.com>).Mar 31 2013, 04:04