Homec4science

Truncate long source lines in Paste search result list snippets

Authored by Giedrius Dubinskas <gd@uber.com> on Oct 20 2015, 21:07.

Description

Truncate long source lines in Paste search result list snippets

Summary:
An attempt to resolve T9600.

  • PhabricatorPasteQuery builds truncated snippet when requested using needSnippet().
  • PhabricatorPasteSearchEngine uses Paste snippet istead of content.
  • PhabricatorSourceCodeView accepts truncated source and type instead of line limit.

Test Plan: Generated some content for Paste application and also added huge JSON oneliner. Checked Paste application pages in browser.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Maniphest Tasks: T9600

Differential Revision: https://secure.phabricator.com/D14313

Details

Committed
Giedrius Dubinskas <gd@uber.com>Oct 20 2015, 21:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4c1463eb569a: Probably fix bad URI construction for Diffusion symbols
Branches
Unknown
Tags
Unknown

Event Timeline

Giedrius Dubinskas <gd@uber.com> committed rPH421c2453e5e4: Truncate long source lines in Paste search result list snippets (authored by Giedrius Dubinskas <gd@uber.com>).Oct 20 2015, 21:07