Homec4science

Add basic support for editing project policies

Authored by epriestley <git@epriestley.com> on Aug 15 2012, 19:44.

Description

Add basic support for editing project policies

Summary:
This case is unusually complicated because there are more rules than most objects will have.

  • Edits are either "joins", "leaves" or "other edits".
  • "Joins" require "can join" or "can edit".
  • "Leaves" don't require any policy.
  • "Other edits" require "can edit".
  • You can't edit away your ability to edit.
  • You can leave a project that you wouldn't be able to rejoin.

Things I'm going to add:

  • Global log of policy changes.
  • bin/policy script for undoing policy changes.
  • Test coverage for these rules.

Test Plan: Made various project visibility edits with various users, joined / left projects, etc. I'll add more complete coverage in the next diff.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D3270

Details

Committed
epriestley <git@epriestley.com>Aug 15 2012, 19:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH51c5a9b06759: Minor; fix a unit test
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH42461b5f06f4: Add basic support for editing project policies (authored by epriestley <git@epriestley.com>).Aug 15 2012, 19:44