Homec4science

Destroy notifications properly from `bin/remove destroy`

Authored by epriestley <git@epriestley.com> on May 18 2015, 21:29.

Description

Destroy notifications properly from bin/remove destroy

Summary: Fixes T8237. This table is unusual and doesn't have an id column, so delete() doesn't actually know how to delete records and fails.

Test Plan:

  • Used bin/remove destroy to destroy an object with notifications, as per T8237.
  • Applied patch.
  • Used bin/remove destroy to get a clean delete.
  • Verified related notifications vanished from notification menu.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8237

Differential Revision: https://secure.phabricator.com/D12907

Details

Committed
epriestley <git@epriestley.com>May 18 2015, 21:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPH107d6db1e8f6: Don't put a spacer line on the bottom of previews
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4250719d1008: Destroy notifications properly from `bin/remove destroy` (authored by epriestley <git@epriestley.com>).May 18 2015, 21:29