Homec4science

Differential - allow setting viewPolicy from web ui during diff creation process

Authored by Bob Trahan <btrahan@phacility.com> on Nov 19 2014, 21:16.

Description

Differential - allow setting viewPolicy from web ui during diff creation process

Summary: Fixes T6152, T6237. This introduces a viewPolicy column to the DifferentialDiff, and re-jiggers the DifferentialDiff policy implementation such that things behave as before once associated with a revision, else use the DifferentialDiff policy column value.

Test Plan: made a diff with a non-standard view policy and noted that policy was still selected in the revision step. arc lint.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6237, T6152

Differential Revision: https://secure.phabricator.com/D10875

Details

Committed
Bob Trahan <btrahan@phacility.com>Nov 19 2014, 21:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7ef236c9a647: Differential - refine selecting a repository diff --> revision workflow
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH435085862892: Differential - allow setting viewPolicy from web ui during diff creation process (authored by Bob Trahan <btrahan@phacility.com>).Nov 19 2014, 21:16