Homec4science

Consider packages when calculating Differential authority

Authored by epriestley <git@epriestley.com> on May 13 2016, 16:23.

Description

Consider packages when calculating Differential authority

Summary:
Ref T10939. This has no effect yet since packages can not actually become reviewers, I'm just inching toward support.

  • When searching for "responsible users", include revisions that need review by packages you have authority over.
  • When calculating review authority, include authority over packages you are a member of (these currently never exist).

Test Plan:
This isn't reachable so I just var_dump()'d stuff and looked at the generated queries, which appeared correct/reasonable.

I'll vet this more thoroughly once packages can actually become reviewers.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15909

Details

Committed
epriestley <git@epriestley.com>May 14 2016, 02:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1793e2f9457b: Use ye new Englishe in ye docs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH44057ad26985: Consider packages when calculating Differential authority (authored by epriestley <git@epriestley.com>).May 14 2016, 02:17