Homec4science

Transactions - hide "mentioned in X" story if you can't see X

Authored by Bob Trahan <btrahan@phacility.com> on Sep 16 2014, 21:12.

Description

Transactions - hide "mentioned in X" story if you can't see X

Summary: ...also re-jiggers all the anchor stuff to use $xaction ID. This seemed like the simplest way once I got in the code, as well as having nice properties for if / when we want to re-add some ajax stuff since the ID is a pretty solid piece of data to key off. Fixes T6083.

Test Plan: mentioned DX in private DX+1. Could see on DX the mention as me and not as the other user. For transactions, I left a comment on Paste and it worked, and I edited an existing transaction and it worked.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T6083

Differential Revision: https://secure.phabricator.com/D10488

Details

Committed
Bob Trahan <btrahan@phacility.com>Sep 16 2014, 21:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPH936ee22de1b8: Differential - label unit / lint results from the commit diff as not applicable
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH444ced16d983: Transactions - hide "mentioned in X" story if you can't see X (authored by Bob Trahan <btrahan@phacility.com>).Sep 16 2014, 21:12