Homec4science

Send only one request at a time from ShapedRequest

Authored by vrana <jakubv@fb.com> on Feb 15 2012, 00:47.

Description

Send only one request at a time from ShapedRequest

Summary:
'this._request' was never set so 'waiting' was always false.
Result was that several requests were sent at once which wastes resources and
leads to weird bugs when responses don't arrive in sending order.

Blame Rev: D258

Test Plan:
Write a comment extremely fast, watch for requests sent.
Add sleep(5) for some inputs to DifferentialCommentPreviewController, verify
correct order.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1612

Details

Committed
vrana <jakubv@fb.com>Feb 15 2012, 00:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPHba05ac595c73: Minor, fix a fatal on Herald Admin controller
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH44b7b4bfc07a: Send only one request at a time from ShapedRequest (authored by vrana <jakubv@fb.com>).Feb 15 2012, 00:58