Homec4science

Fix two diff rendering bugs

Authored by epriestley <git@epriestley.com> on Jan 15 2013, 17:07.

Description

Fix two diff rendering bugs

Summary:

  • The order of operations for file changes is wrong. We need to wrap them in a table, then render the changeset talbe around that table.
  • Line data was being set to late, so renderShield() got the wrong line count and rendered empty diffs behind, e.g., generated changes.

Test Plan: Looked at an image change with property changes. Clicked "show file contents" on a generated file.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D4432

Details

Committed
epriestley <git@epriestley.com>Jan 15 2013, 17:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPH894666f9753f: Move crumbs to first element of content-view
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4566b86376bf: Fix two diff rendering bugs (authored by epriestley <git@epriestley.com>).Jan 15 2013, 17:07