Homec4science

Improve scrolling behavior for lightboxes in Safari

Authored by epriestley <git@epriestley.com> on Oct 23 2012, 21:00.

Description

Improve scrolling behavior for lightboxes in Safari

Summary: Our "html { overflow-y: scroll; }" makes Safari flip out when we put "hidden" on body. Instead, put the scroll on body and then replace it with hidden when the lightbox is visible.

Test Plan: In Safari, the body scrollbar vanishes when the lightbox is active and scrolling no longer causes spasms.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3800

Details

Committed
epriestley <git@epriestley.com>Oct 23 2012, 21:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPH70dc3f5004a0: Show all available action list icons in UIExamples
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4596e3876b5f: Improve scrolling behavior for lightboxes in Safari (authored by epriestley <git@epriestley.com>).Oct 23 2012, 21:00