Homec4science

Releeph: use relative URIs

Authored by Edward Speyer <edward@fb.com> on May 22 2013, 16:42.

Description

Releeph: use relative URIs

Summary: I used the PhabricatorEnv::getProductionURI() in too many places to build Releeph URIs. The only places that should need full URIs are the links generated for Releeph emails, and in Conduit responses that link to Releeph objects.

Test Plan:

  • Grep for getProductionURI() in Releeph, and make sure only sensible, non-DOM building places use it.
  • Inspect the Releeph DOM to make sure hrefs etc. are relative.

Reviewers: wez, epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5999

Details

Committed
Edward Speyer <edward@fb.com>May 22 2013, 16:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPH824f93462279: Diffusion - move commit parents query to conduit
Branches
Unknown
Tags
Unknown

Event Timeline

Edward Speyer <edward@fb.com> committed rPH46929207517c: Releeph: use relative URIs (authored by Edward Speyer <edward@fb.com>).May 22 2013, 16:42