Homec4science

Fix calendar z-index and Conpherence/Calendar integration

Authored by epriestley <git@epriestley.com> on May 1 2015, 02:09.

Description

Fix calendar z-index and Conpherence/Calendar integration

Summary:
Fixes T7975. Long ago, this element looked like this when you expanded it:

+-------------------+
|     3 4 5 6 7   X |
| 8 9 1 2 3 4 5 +---+
| 6 7 8 9 1 2 3 |
| 4 5 6 7       |
+---------------+

That was why the icon needed a z-index. See T5880. @chad fixed this a while ago so it looks like this:

+---------------+
|     3 4 5 6 7 | X
| 8 9 1 2 3 4 5 |
| 6 7 8 9 1 2 3 |
| 4 5 6 7       |
+---------------+

...but we never stripped the z-index off, causing the bug in T7975.

Also fix some collateral damage from the recent calendar refactoring and the Conpherence widget.

Test Plan:

  • Created a new event via Conpherence
  • Created a new event normally.
  • Browsed a typeahead in Calendar without icons showing through.

Reviewers: lpriestley, chad, btrahan

Reviewed By: btrahan

Subscribers: chad, epriestley

Maniphest Tasks: T7975

Differential Revision: https://secure.phabricator.com/D12639

Details

Committed
epriestley <git@epriestley.com>May 1 2015, 02:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb199f7066c9c: Conpherence - add support for linking directly to messages regardless of age of…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4699c2901765: Fix calendar z-index and Conpherence/Calendar integration (authored by epriestley <git@epriestley.com>).May 1 2015, 02:09