Remove all `device = true` from page construction
46d9bebc8430
Actions

Authored by epriestley <git@epriestley.com> on Jun 24 2014, 00:18.

Description

Remove all device = true from page construction

Summary: Fixes T5446. Depends on D9687.

Test Plan: Mostly regexp'd this. Lint doesn't complain.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley, hach-que

Maniphest Tasks: T5446

Differential Revision: https://secure.phabricator.com/D9690

Details

Committed

epriestley <git@epriestley.com>

Jun 24 2014, 00:18

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHca6bd2647588: Set `device` to `false` for all pages which don't specify device readiness

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH46d9bebc8430: Remove all `device = true` from page construction (authored by epriestley <git@epriestley.com>).Jun 24 2014, 00:18

Changes (195)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path
	M			src/applications/auth/controller/PhabricatorAuthConfirmLinkController.php
	M			src/applications/auth/controller/PhabricatorAuthController.php
	M			src/applications/auth/controller/PhabricatorAuthLinkController.php
	M			src/applications/auth/controller/PhabricatorAuthLoginController.php
	M			src/applications/auth/controller/PhabricatorAuthNeedsApprovalController.php
	M			src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php
	M			src/applications/auth/controller/PhabricatorAuthRegisterController.php
	M			src/applications/auth/controller/PhabricatorAuthStartController.php
	M			src/applications/auth/controller/PhabricatorEmailLoginController.php
	M			src/applications/auth/controller/PhabricatorEmailVerificationController.php
	M			src/applications/auth/controller/PhabricatorMustVerifyEmailController.php
	M			src/applications/auth/controller/config/PhabricatorAuthEditController.php
	M			src/applications/auth/controller/config/PhabricatorAuthListController.php
	M			src/applications/auth/controller/config/PhabricatorAuthNewController.php
	M			src/applications/calendar/controller/PhabricatorCalendarBrowseController.php
	M			src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
	M			src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
	M			src/applications/calendar/controller/PhabricatorCalendarViewController.php
	M			src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php
	M			src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
	M			src/applications/conduit/controller/PhabricatorConduitAPIController.php
	M			src/applications/conduit/controller/PhabricatorConduitConsoleController.php
	M			src/applications/conduit/controller/PhabricatorConduitLogController.php
	M			src/applications/conduit/controller/PhabricatorConduitTokenController.php
	M			src/applications/config/controller/PhabricatorConfigAllController.php
	M			src/applications/config/controller/PhabricatorConfigEditController.php
	M			src/applications/config/controller/PhabricatorConfigGroupController.php
	M			src/applications/config/controller/PhabricatorConfigIssueListController.php
	M			src/applications/config/controller/PhabricatorConfigIssueViewController.php
	M			src/applications/config/controller/PhabricatorConfigListController.php
	M			src/applications/config/controller/PhabricatorConfigWelcomeController.php
	M			src/applications/conpherence/controller/ConpherenceListController.php
	M			src/applications/conpherence/controller/ConpherenceViewController.php
	M			src/applications/countdown/controller/PhabricatorCountdownEditController.php
	M			src/applications/countdown/controller/PhabricatorCountdownViewController.php
	M			src/applications/daemon/controller/PhabricatorDaemonLogListController.php
	M			src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php
	M			src/applications/dashboard/controller/PhabricatorDashboardEditController.php
	M			src/applications/dashboard/controller/PhabricatorDashboardHistoryController.php
	M			src/applications/dashboard/controller/PhabricatorDashboardManageController.php
	M			src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
	M			src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php
	M			src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php
	M			src/applications/dashboard/controller/PhabricatorDashboardViewController.php
	M			src/applications/differential/controller/DifferentialDiffCreateController.php
	M			src/applications/differential/controller/DifferentialDiffViewController.php
	M			src/applications/differential/controller/DifferentialRevisionEditController.php
	M			src/applications/differential/controller/DifferentialRevisionViewController.php
	M			src/applications/diffusion/controller/DiffusionBrowseDirectoryController.php
	M			src/applications/diffusion/controller/DiffusionBrowseSearchController.php
	M			src/applications/diffusion/controller/DiffusionCommitEditController.php
	M			src/applications/diffusion/controller/DiffusionExternalController.php
	M			src/applications/diffusion/controller/DiffusionHistoryController.php
	M			src/applications/diffusion/controller/DiffusionLintDetailsController.php
	M			src/applications/diffusion/controller/DiffusionPushEventViewController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryEditLocalController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php
	M			src/applications/diffusion/controller/DiffusionRepositoryNewController.php
	M			src/applications/diffusion/controller/DiffusionSymbolController.php
	M			src/applications/diviner/controller/DivinerAtomController.php
	M			src/applications/diviner/controller/DivinerBookController.php
	M			src/applications/diviner/controller/DivinerFindController.php
	M			src/applications/diviner/controller/DivinerMainController.php
	M			src/applications/drydock/controller/DrydockBlueprintCreateController.php
	M			src/applications/drydock/controller/DrydockBlueprintEditController.php
	M			src/applications/drydock/controller/DrydockBlueprintViewController.php
	M			src/applications/drydock/controller/DrydockConsoleController.php
	M			src/applications/drydock/controller/DrydockLeaseViewController.php
	M			src/applications/drydock/controller/DrydockResourceViewController.php
	M			src/applications/feed/controller/PhabricatorFeedDetailController.php
	M			src/applications/files/controller/PhabricatorFileInfoController.php
	M			src/applications/files/controller/PhabricatorFileUploadController.php
	M			src/applications/harbormaster/controller/HarbormasterBuildViewController.php
	M			src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
	M			src/applications/harbormaster/controller/HarbormasterPlanEditController.php
	M			src/applications/harbormaster/controller/HarbormasterPlanViewController.php
	M			src/applications/harbormaster/controller/HarbormasterStepEditController.php
	M			src/applications/herald/controller/HeraldNewController.php
	M			src/applications/herald/controller/HeraldRuleController.php
	M			src/applications/herald/controller/HeraldRuleEditHistoryController.php
	M			src/applications/herald/controller/HeraldRuleViewController.php
	M			src/applications/herald/controller/HeraldTestConsoleController.php
	M			src/applications/herald/controller/HeraldTranscriptController.php
	M			src/applications/home/controller/PhabricatorHomeMainController.php
	M			src/applications/home/controller/PhabricatorHomeQuickCreateController.php
	M			src/applications/legalpad/controller/LegalpadDocumentEditController.php
	M			src/applications/legalpad/controller/LegalpadDocumentSignController.php
	M			src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php
	M			src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php
	M			src/applications/legalpad/controller/LegalpadDocumentViewController.php
	M			src/applications/macro/controller/PhabricatorMacroAudioController.php
	M			src/applications/macro/controller/PhabricatorMacroEditController.php
	M			src/applications/macro/controller/PhabricatorMacroViewController.php
	M			src/applications/mailinglists/controller/PhabricatorMailingListsEditController.php
	M			src/applications/maniphest/controller/ManiphestTaskDetailController.php
	M			src/applications/maniphest/controller/ManiphestTaskEditController.php
	M			src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
	M			src/applications/meta/controller/PhabricatorApplicationEditController.php
	M			src/applications/notification/controller/PhabricatorNotificationListController.php
	M			src/applications/nuance/controller/NuanceItemEditController.php
	M			src/applications/nuance/controller/NuanceItemViewController.php
	M			src/applications/nuance/controller/NuanceQueueEditController.php
	M			src/applications/nuance/controller/NuanceQueueViewController.php
	M			src/applications/nuance/controller/NuanceRequestorEditController.php
	M			src/applications/nuance/controller/NuanceRequestorViewController.php
	M			src/applications/nuance/controller/NuanceSourceEditController.php
	M			src/applications/nuance/controller/NuanceSourceViewController.php
	M			src/applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php
	M			src/applications/oauthserver/controller/client/PhabricatorOAuthClientViewController.php
	M			src/applications/owners/controller/PhabricatorOwnersDetailController.php
	M			src/applications/owners/controller/PhabricatorOwnersEditController.php
	M			src/applications/owners/controller/PhabricatorOwnersListController.php
	M			src/applications/passphrase/controller/PassphraseCredentialCreateController.php
	M			src/applications/passphrase/controller/PassphraseCredentialEditController.php
	M			src/applications/passphrase/controller/PassphraseCredentialViewController.php
	M			src/applications/paste/controller/PhabricatorPasteEditController.php
	M			src/applications/paste/controller/PhabricatorPasteViewController.php
	M			src/applications/people/controller/PhabricatorPeopleCalendarController.php
	M			src/applications/people/controller/PhabricatorPeopleCreateController.php
	M			src/applications/people/controller/PhabricatorPeopleLdapController.php
	M			src/applications/people/controller/PhabricatorPeopleNewController.php
	M			src/applications/people/controller/PhabricatorPeopleProfileController.php
	M			src/applications/people/controller/PhabricatorPeopleProfileEditController.php
	M			src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
	M			src/applications/phame/controller/blog/PhameBlogEditController.php
	M			src/applications/phame/controller/blog/PhameBlogListController.php
	M			src/applications/phame/controller/blog/PhameBlogViewController.php
	M			src/applications/phame/controller/post/PhamePostEditController.php
	M			src/applications/phame/controller/post/PhamePostListController.php
	M			src/applications/phame/controller/post/PhamePostNewController.php
	M			src/applications/phame/controller/post/PhamePostPublishController.php
	M			src/applications/phame/controller/post/PhamePostViewController.php
	M			src/applications/phlux/controller/PhluxEditController.php
	M			src/applications/phlux/controller/PhluxListController.php
	M			src/applications/phlux/controller/PhluxViewController.php
	M			src/applications/pholio/controller/PholioMockEditController.php
	M			src/applications/pholio/controller/PholioMockViewController.php
	M			src/applications/phortune/controller/PhortuneAccountBuyController.php
	M			src/applications/phortune/controller/PhortuneAccountViewController.php
	M			src/applications/phortune/controller/PhortunePaymentMethodEditController.php
	M			src/applications/phortune/controller/PhortunePaymentMethodListController.php
	M			src/applications/phortune/controller/PhortunePaymentMethodViewController.php
	M			src/applications/phortune/controller/PhortuneProductEditController.php
	M			src/applications/phortune/controller/PhortuneProductListController.php
	M			src/applications/phortune/controller/PhortuneProductViewController.php
	M			src/applications/phortune/controller/PhortuneProviderController.php
	M			src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php
	M			src/applications/phragment/controller/PhragmentBrowseController.php
	M			src/applications/phragment/controller/PhragmentCreateController.php
	M			src/applications/phragment/controller/PhragmentHistoryController.php
	M			src/applications/phragment/controller/PhragmentPolicyController.php
	M			src/applications/phragment/controller/PhragmentSnapshotCreateController.php
	M			src/applications/phragment/controller/PhragmentSnapshotViewController.php
	M			src/applications/phragment/controller/PhragmentUpdateController.php
	M			src/applications/phragment/controller/PhragmentVersionController.php
	M			src/applications/phriction/controller/PhrictionDiffController.php
	M			src/applications/phriction/controller/PhrictionDocumentController.php
	M			src/applications/phriction/controller/PhrictionEditController.php
	M			src/applications/phriction/controller/PhrictionHistoryController.php
	M			src/applications/ponder/controller/PonderAnswerEditController.php
	M			src/applications/ponder/controller/PonderAnswerHistoryController.php
	M			src/applications/ponder/controller/PonderQuestionEditController.php
	M			src/applications/ponder/controller/PonderQuestionHistoryController.php
	M			src/applications/ponder/controller/PonderQuestionViewController.php
	M			src/applications/project/controller/PhabricatorProjectBoardEditController.php
	M			src/applications/project/controller/PhabricatorProjectBoardViewController.php
	M			src/applications/project/controller/PhabricatorProjectColumnDetailController.php
	M			src/applications/project/controller/PhabricatorProjectCreateController.php
	M			src/applications/project/controller/PhabricatorProjectEditDetailsController.php
	M			src/applications/project/controller/PhabricatorProjectEditMainController.php
	M			src/applications/project/controller/PhabricatorProjectEditPictureController.php
	M			src/applications/project/controller/PhabricatorProjectMembersEditController.php
	M			src/applications/project/controller/PhabricatorProjectProfileController.php
	M			src/applications/releeph/controller/branch/ReleephBranchCreateController.php
	M			src/applications/releeph/controller/branch/ReleephBranchEditController.php
	M			src/applications/releeph/controller/branch/ReleephBranchHistoryController.php
	M			src/applications/releeph/controller/product/ReleephProductCreateController.php
	M			src/applications/releeph/controller/product/ReleephProductHistoryController.php
	M			src/applications/releeph/controller/request/ReleephRequestEditController.php
	M			src/applications/search/controller/PhabricatorApplicationSearchController.php
	M			src/applications/search/controller/PhabricatorSearchEditController.php
	M			src/applications/settings/controller/PhabricatorSettingsMainController.php
	M			src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
	M			src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
	M			src/applications/tokens/controller/PhabricatorTokenGivenController.php
	M			src/applications/tokens/controller/PhabricatorTokenLeaderController.php
	M			src/applications/uiexample/controller/PhabricatorUIExampleRenderController.php