Homec4science

Provide an attached-to-visible-object policy exception for files

Authored by epriestley <git@epriestley.com> on Oct 1 2013, 17:43.

Description

Provide an attached-to-visible-object policy exception for files

Summary:
Ref T603. This uses the existing edges (from Conpherence) to record that a file is attached to an object, and uses those edges to create a policy exception: if you can view an attached object, you can view a file.

I'm going to combine this with restrictive defaults to satisfy the other half of the equation (that files you attach to a conpherence usually shouldn't be public by default).

Test Plan:

  • Loaded /files/.
  • Uploaded a file to a Conpherence, looked at it in Files, saw the attachment.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7182

Details

Committed
epriestley <git@epriestley.com>Oct 1 2013, 17:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfc579953306c: Fix a typo in `differential.querydiffs`
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH472be5e26e6a: Provide an attached-to-visible-object policy exception for files (authored by epriestley <git@epriestley.com>).Oct 1 2013, 17:43