Homec4science

Fix an unusual nonterminating task graph node

Authored by epriestley <git@epriestley.com> on Jan 17 2017, 16:32.

Description

Fix an unusual nonterminating task graph node

Summary:
Fixes T12114. There were a couple of bugs here:

  • We could draw too many joining lines if a node had a parent with multiple descendants.
  • We could incorrectly ignore columns because of an unset().

I think this fixes both things without collateral damage. This whole thing is a little hard to understand/debug and has grown beyond its original scope, so I'll probably rewrite it if there are more issues.

Test Plan:

  • Unit tests.
  • My local repro is clean now:

{F2424920}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12114

Differential Revision: https://secure.phabricator.com/D17211

Details

Committed
epriestley <git@epriestley.com>Jan 17 2017, 18:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa4a948561283: Hide dropdown menus when users click workflow items
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH48187cdbbe99: Fix an unusual nonterminating task graph node (authored by epriestley <git@epriestley.com>).Jan 17 2017, 18:18