Homec4science

Fix rendering of comments deleted by editing

Authored by epriestley <git@epriestley.com> on Mar 14 2014, 19:53.

Description

Fix rendering of comments deleted by editing

Summary:
Fixes T4609. Steps are:

  • Make a comment.
  • Edit it.
  • Delete all the text.

We expect to see "This comment has been deleted." -- instead, things currently render goofy.

Root cause is that hasComment() means both "comment object exists" and "comment object is nonempty".

Test Plan: {F128862}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Maniphest Tasks: T4609

Differential Revision: https://secure.phabricator.com/D8533

Details

Committed
epriestley <git@epriestley.com>Mar 14 2014, 19:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH838f78128544: Add a robots.txt file to disallow /diffusion/
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH48910537b939: Fix rendering of comments deleted by editing (authored by epriestley <git@epriestley.com>).Mar 14 2014, 19:53