Homec4science

Validate settings before writing them to the user cache

Authored by epriestley <git@epriestley.com> on Dec 7 2016, 21:48.

Description

Validate settings before writing them to the user cache

Summary:
Fixes T11960. In D16998 I removed some code which validated settings on read to improve performance, but lost this replacement validation in shuffling the patch stack.

This restores similar validation before we write the cache. This has the same effect, it's just faster.

Also, bump the cache key to wipe out anything that got bitten (like my account on secure rendering dates wrong).

Test Plan:

  • Edited settings, verified the edits held.
  • Faked invalid settings, saw the check throw exceptions.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11960

Differential Revision: https://secure.phabricator.com/D17008

Details

Committed
epriestley <git@epriestley.com>Dec 7 2016, 22:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe8d9c676b1a7: Fix a bad link in the database partitioning docs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH495092613019: Validate settings before writing them to the user cache (authored by epriestley <git@epriestley.com>).Dec 7 2016, 22:34