Homec4science

Don't repeat the diff property table when clicking "show more"

Authored by epriestley <git@epriestley.com> on Jun 20 2011, 22:49.

Description

Don't repeat the diff property table when clicking "show more"

Summary:
If you "chmod +x" a file and then generate a diff and click "show 20 lines" on
that diff, you get another janky copy of the property table. Render the property
table only for top-level rendering requests.

This started happening after D409, which fixed the far-more-obvious bug of these
things never showing up. We must have changed the logic at some point since this
side effect was surprising to me. :P

Test Plan:
Created a diff with changes and +x, clicked "show 20 lines".

  • Original diff had file property header table thing, showing the +x.
  • New context brought in by "show 20 lines" didn't have it anymore.

Reviewed By: jungejason
Reviewers: aran, jungejason, tuomaspelkonen
CC: aran, epriestley, jungejason
Differential Revision: 482

Details

Committed
epriestley <git@epriestley.com>Jun 21 2011, 00:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2330a1e95476: Improve visibility of the keyboard shortcut focus reticle
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4a55af7857da: Don't repeat the diff property table when clicking "show more" (authored by epriestley <git@epriestley.com>).Jun 21 2011, 00:54